-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rectangle mesh generation testing #3356
Conversation
e13b681
to
5dce221
Compare
5dce221
to
5809866
Compare
|
5809866
to
729808f
Compare
Thanks for pointing me to this function. I think to make proper use of this and to simplify the tests in this and the related PR's we probably want to split the testing of the generation (everything prior to call to What remains an open problem with this restructuring would be the question of how to check the mesh parallelization effectively (controlling in test cases which process owns which node and where ghost nodes are generated). |
Is this ready, or does it need changes based on @jpdean's comment? |
I'd say its good to go, and we can adapt later on. Addressing the before mentioned issue will require more changes, than only the tests, so maybe a good idea to separate it from this. |
TEMPLATE_TEST_CASE("Rectangle quadrilateral mesh", | ||
"[mesh][rectangle][quadrilateral]", float, double) | ||
{ | ||
using T = TestType; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is TestType
defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is part of the catch macro TEMPLATE_TEST_CASE
. Here, its either float
or double
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering does this add anything over what we can test (more easily) from Python?
In principle these tests could be moved to python, I think. Nevertheless I would push for keeping them here in the cpp part. We are strictly unit testing here and thus should avoid as many additional layers as possible. For example the related tests with parallel cases (in other PRs) currently are not transferable to python due to |
Superseded by #3359 |
This introduces explicit (index based) testing of the mesh generation for 2d rectangles. For now only in sequential.
These data structures are needed for more complex test cases (multigrid), following in other PRs.
Also this gives a good baseline/examples for the fixing of #1741